This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] turtle-v2 credentials change hasLocal,hasRemote bahviour #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
suggested changes
Aug 12, 2020
| credentialsJSONRaw = JSON.parse(credentialsJSONContents); | ||
| } catch (err) { | ||
| throw new Error( | ||
| `credentials.json must exist in the project root directory and consist a valid JSON` |
There was a problem hiding this comment.
Suggested change
| `credentials.json must exist in the project root directory and consist a valid JSON` | |
| `credentials.json must exist in the project root directory and contain a valid JSON` |
| `credentials.json must exist in the project root directory and consist a valid JSON` | ||
| ); | ||
| } | ||
| return credentialsJSONRaw; |
There was a problem hiding this comment.
Suggested change
| return credentialsJSONRaw; |
| let credentialsJSONRaw; | ||
| try { | ||
| const credentialsJSONContents = await fs.readFile(credentialsJsonFilePath, 'utf8'); | ||
| credentialsJSONRaw = JSON.parse(credentialsJSONContents); |
There was a problem hiding this comment.
Suggested change
| credentialsJSONRaw = JSON.parse(credentialsJSONContents); | |
| return JSON.parse(credentialsJSONContents); |
| @@ -116,7 +107,21 @@ async function readAsync(projectDir: string): Promise<CredentialsJson> { | |||
| return credentialsJson; | |||
| } | |||
|
|
|||
| async function readRawAsync(projectDir: string): Promise<any> { | |||
| const credentialsJsonFilePath = path.join(projectDir, 'credentials.json'); | |||
| let credentialsJSONRaw; | |||
There was a problem hiding this comment.
Suggested change
| let credentialsJSONRaw; |
Comment on lines
15
to
24
| //const originalWarn = console.warn; | ||
| //const originalLog = console.log; | ||
| //beforeAll(() => { | ||
| // console.warn = jest.fn(); | ||
| // console.log = jest.fn(); | ||
| //}); | ||
| //afterAll(() => { | ||
| // console.warn = originalWarn; | ||
| // console.log = originalLog; | ||
| //}); |
There was a problem hiding this comment.
forgot to uncomment
wkozyra95
force-pushed
the
@wkozyra95/change-detecting-local-credentials
branch
2 times, most recently
from
3f93d29
to
5617672
Compare
dsokal
approved these changes
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
It's not clear what credentials are used during build, misconfiguration of credentials.json might cause expo-cli to use remote ones without any info for the user