This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] revert PR #2404 and remove encoding from IosPushCredentials #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
approved these changes
Jul 28, 2020
CHANGELOG.md
Outdated
| @@ -17,7 +17,7 @@ This is the log of notable changes to Expo CLI and related packages. | |||
| - [xdl] Fix incorrect check of the packager port in the "setOptionsAsync" function [#2270](https://github.com/expo/expo-cli/issues/2270) | |||
| - [expo-cli] expo upload:android - Fix passing archive type from command line [#2383](https://github.com/expo/expo-cli/pull/2383) | |||
| - [expo-cli] check `when` field when inquirer is used in noninteractive mode [#2393](https://github.com/expo/expo-cli/pull/2393) | |||
| - [expo-cli] base64 decode when saving p8 file [#2404](https://github.com/expo/expo-cli/pull/2404) | |||
| - [expo-cli] do not base64 encode push notification [#2406](https://github.com/expo/expo-cli/pull/2406) | |||
There was a problem hiding this comment.
Suggested change
| - [expo-cli] do not base64 encode push notification [#2406](https://github.com/expo/expo-cli/pull/2406) | |
| - [expo-cli] do not base64 encode push notification [#2406](https://github.com/expo/expo-cli/pull/2406) |
wkozyra95
force-pushed
the
@wkozyra95/remove-base-encoding-for-push-key
branch
from
c2d4353
to
f6c7e56
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting changes made in #2404 (I initially assumed that push key is base encoded on a server)
Remove encoding from
getPushKeyFromParams