This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] check when field when inquirer is used in noninteractive mode
#2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
changed the title
when field when prompting in noninteractive modewhen field when inquirer is used in noninteractive mode
wkozyra95
force-pushed
the
@wkozyra95/check-when-fn-in-noninteractive-mode
branch
from
b240a01
to
4d2d80e
Compare
dsokal
approved these changes
Jul 24, 2020
quinlanj
approved these changes
Jul 24, 2020
| if (!('when' in question)) { | ||
| return true; | ||
| } else if (typeof question.when === 'function') { | ||
| return question.when({}); |
There was a problem hiding this comment.
It's a bit confusing for me when i read this and i need to look up inquirer docs to make sense of what kind of object when should be. It'd be helpful if you had some comments explaining that in the case when is a function, it expects to take the user's answers object, which is empty in the case of non-interactive
wkozyra95
force-pushed
the
@wkozyra95/check-when-fn-in-noninteractive-mode
branch
from
4d2d80e
to
b4023f6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2327