This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] submission service: fix passing archive type from command line #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
force-pushed
the
@dsokal/ss-fix-specifying-archive-type
branch
from
69e7eb6
to
ae05e92
Compare
wkozyra95
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://forums.expo.io/t/github-actions-uploading-android-from-ubuntu-runner-use-submission-service/40593
The command option for specifying archive type is called
--type, yet in the codebase, we were usingarchiveType. We made this error because the commander options weren't typed.Things I did in this PR:
archiveTypetotype.