Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[xdl] don't log dots when downloading gradle #2355

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Jul 14, 2020

Why

From expo/turtle#221:

When running turtle build:android the logger outputs a lot of dots, which introduces noise for later analysis

How

I added a logger line transformer which drops lines that only contain dots.

Test Plan

  • I yarn-linked @expo/xdl in my local turtle-cli repository.
  • I ran an Android build and verified that no dots are displayed when Gradle Wrapper is downloading the appropriate Gradle version: Screenshot 2020-07-14 at 15 31 38

@brentvatne
Copy link
Member

.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
.
nice

@dsokal dsokal merged commit d7aadc7 into master Jul 15, 2020
@dsokal dsokal deleted the @dsokal/gradle-log-noise branch July 15, 2020 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants