This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add owner field support to expo start #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
approved these changes
Jul 1, 2020
| export async function getSignedManifestStringAsync( | ||
| manifest: ExpoConfig, | ||
| currentSession: { sessionSecret: string } | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| ) { | |
| ): Promise<string> { |
| return response; | ||
| } | ||
|
|
||
| export function getUnsignedManifestString(manifest: ExpoConfig) { |
There was a problem hiding this comment.
Suggested change
| export function getUnsignedManifestString(manifest: ExpoConfig) { | |
| export function getUnsignedManifestString(manifest: ExpoConfig): string { |
Comment on lines
23
to
27
| expect(options.data.args).toEqual({ | ||
| remoteUsername: mockManifest.owner, | ||
| remotePackageName: mockManifest.slug, | ||
| }); | ||
| expect(options.data.manifest).toEqual(mockManifest); |
There was a problem hiding this comment.
Hmmm, it seems a little weird to me that you're calling expect in a mock 🤔 I prefer to call expect only in test cases. Maybe assert would make more sense?
There was a problem hiding this comment.
Based on your feedback, I rewrote the mock so that the custom mock implementation is not needed at all and all the assertions are inside the test case. I think it made the test better, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2242.