Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

fix(expo-cli): credentials:manager read credentials fix #2311

Merged
merged 2 commits into from
Jun 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ This is the log of notable changes to Expo CLI and related packages.

### 🐛 Bug fixes

- Fix `expo credentials:manager` listing all credentials on android and respect owner field` ([#2311](https://github.com/expo/expo-cli/pull/2311) by [@wkozyra95](https://github.com/wkozyra95)).

### 📦 Packages updated

## [Tue Jun 23 17:55:00 2020 -0700](https://github.com/expo/expo-cli/commit/4bc73721d5a46fcac35096a0e86a1ceaa333b459)
Expand Down
9 changes: 4 additions & 5 deletions packages/expo-cli/src/credentials/views/Select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,11 @@ export class SelectIosExperience implements IView {
}

export class SelectAndroidExperience implements IView {
private androidCredentials: AndroidCredentials[] = [];
private askAboutProjectMode = true;

async open(ctx: Context): Promise<IView | null> {
if (ctx.hasProjectContext && this.askAboutProjectMode) {
const experienceName = `@${ctx.user.username}/${ctx.manifest.slug}`;
const experienceName = `@${ctx.manifest.owner || ctx.user.username}/${ctx.manifest.slug}`;
const { runProjectContext } = await prompt([
{
type: 'confirm',
Expand All @@ -133,15 +132,15 @@ export class SelectAndroidExperience implements IView {
this.askAboutProjectMode = false;

const credentials = await ctx.android.fetchAll();
await displayAndroidCredentials(this.androidCredentials);
await displayAndroidCredentials(Object.values(credentials));

const question: Question = {
type: 'list',
name: 'experienceName',
message: 'Select application',
choices: this.androidCredentials.map((cred, index) => ({
choices: Object.values(credentials).map(cred => ({
name: cred.experienceName,
value: index,
value: cred.experienceName,
})),
pageSize: Infinity,
};
Expand Down