Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

fix: remove opt-in-google-play-signing #2247

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

wkozyra95
Copy link
Contributor

@wkozyra95 wkozyra95 commented Jun 10, 2020

  • there is only very small number of users that could use it (apps from before 2017 that didn't migrate up until now)
  • there are cases were people with enabled app signing ran this command and replaced their credentials with new (invalid ones) and needed to contact google support to reset it
  • alternative to this command is following google instructions and uploading new keystore to expo when done: https://docs.expo.io/distribution/app-signing/#android

@wkozyra95 wkozyra95 requested review from fson and dsokal June 10, 2020 09:26
Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Please update the changelog!

@fson
Copy link
Contributor

fson commented Jun 11, 2020

I updated the description so that anyone looking at the PR can see why it was removed (without access to the Slack message).

@wkozyra95 could you also make sure that the documentation still referring to this command at https://docs.expo.io/distribution/app-signing/#android gets updated?

@wkozyra95 wkozyra95 merged commit 9a44da0 into master Jun 12, 2020
@wkozyra95 wkozyra95 deleted the @wkozyra95/remove-app-signing-opt-in-command branch June 12, 2020 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants