This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add CWD parameter to child process spawn #2220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am a maintainer of React Native Tools VS Code extension. The extension is used for debugging React Native (including Expo) applications.
We faced the issue, when we were trying to use dynamic project configuration and babel-plugin-dotenv-import. Our extension uses
@expo/xdl
package to start Expo server. But when theevalConfig
method is being executed, we get an error that@env
module doesn't exist. We found out that this happens due to incorrect CWD parameter in case of usage of this function within VS Code context. When we start the extensionprocess.cwd
isn't the same as the project root (on macOS it is/
). But we found out that if we add correct CWD to spawn options, everything works fine.This fix should increase the stability of
evalConfig
method work.