Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[cli] fix skip creds flag #2213

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[cli] fix skip creds flag #2213

merged 1 commit into from
Jun 4, 2020

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jun 2, 2020 •
edited by dsokal
Loading

fix the skip-credentials-check flag so it doesnt prompt for apple credentials

testing

  • manual checks
  • current tests pass

@quinlanj quinlanj requested review from dsokal and wkozyra95 June 2, 2020 19:18
dsokal
dsokal approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, Quin! Looks good to me. I left one inline comment.

packages/expo-cli/src/commands/build/ios/IOSBuilder.ts Show resolved Hide resolved
@quinlanj quinlanj merged commit 50edd2a into master Jun 4, 2020
@quinlanj quinlanj deleted the @quin/fixSkipCredCheck branch June 4, 2020 04:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dsokal dsokal dsokal approved these changes

@wkozyra95 wkozyra95 Awaiting requested review from wkozyra95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quinlanj @dsokal