[xdl] clean up Expo.plist artifacts left behind by IosPlist util

[esamelson]

The IosPlist util leaves behind some artifacts (*.json, *.plist.bak) which may be confusing to users who aren't expecting them.

In particular, users running expo publish in a bare workflow project with expo-updates may find these extra files (which come from modifying the data in the Expo.plist config file) confusing. Their utility is limited -- since most people are using version control there's no need to have separate backup files in the same folder. So in this case we should just delete those files after the IosPlist.modifyAsync operation completes successfully.

Test plan

expo init, bare-minimum template, expo publish

• latest expo-cli expo publish produces Expo.json and Expo.plist.bak files in the Supporting dir
• after this change, expo publish no longer produces those files
• deleting files that don't exist with fs.removeSync is a no-op

[brentvatne]

should be able to use

expo-cli/packages/xdl/src/detach/IosPlist.ts

Lines 95 to 107 in 6972d77

	async function cleanBackupAsync(plistPath: string, plistName: string, restoreOriginal = true) {
	let plistFilename = _getNormalizedPlistFilename(plistName);
	let configPlistName = path.join(plistPath, plistFilename);
	let configFilename = path.join(plistPath, `${plistName}.json`);
	const backupPlistPath = `${configPlistName}.bak`;
	if (restoreOriginal && (await fs.pathExists(backupPlistPath))) {
	await fs.copy(backupPlistPath, configPlistName);
	}
	await fs.remove(backupPlistPath);
	await fs.remove(configFilename);
	}

instead