This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Remove exp.json support #2017
Merged
Remove exp.json support #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2017 +/- ##
=======================================
Coverage 44.66% 44.66%
=======================================
Files 112 112
Lines 4777 4777
Branches 1148 1148
=======================================
Hits 2133 2133
Misses 1858 1858
Partials 786 786 |
fson
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Nice! 👍
Would be good to update/remove these comments too:
expo-cli/packages/xdl/src/detach/Detach.js
Line 132 in 548ac8b
expo-cli/packages/xdl/src/detach/Detach.js
Line 225 in 548ac8b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.