Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Print warning when running on newer version of Node.js #1992

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Print warning when running on newer version of Node.js #1992

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf60a59
Print warning when running on newer version of Node.js
LinusU Apr 25, 2020
a931574
Update packages/expo-cli/bin/expo.js
brentvatne Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions packages/expo-cli/bin/expo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,29 @@ const isSupported = supportedVersions.some(function(supported) {
return semver.satisfies(version, supported.range);
});

if (isSupported) {
require('../build/exp.js').run('expo');
} else {
const versionInfo = supportedVersions
.map(function(supported) {
return '* ' + supported.range + ' (' + supported.name + ')';
})
.join('\n');
const versionInfo = supportedVersions
.map(supported => '* ' + supported.range + ' (' + supported.name + ')')
.join('\n');

const maxSupportedVersion = supportedVersions[supportedVersions.length - 1];
const versionIsHigherThanSupported = semver.gtr(version, maxSupportedVersion.range);
const maxSupportedVersion = supportedVersions[supportedVersions.length - 1];
const versionIsHigherThanSupported = semver.gtr(version, maxSupportedVersion.range);

if (versionIsHigherThanSupported) {
console.error(
chalk.yellow(
`WARNING: Node.js version ${version} has not yet been tested.\n\n` +
brentvatne marked this conversation as resolved.
Show resolved Hide resolved
'expo-cli supports following Node.js versions:\n' +
versionInfo
)
);
}

if (isSupported || versionIsHigherThanSupported) {
require('../build/exp.js').run('expo');
} else {
console.error(
chalk.red(
'ERROR: Node.js version ' +
version +
` is ${versionIsHigherThanSupported ? 'not yet' : 'no longer'} supported.\n\n` +
`ERROR: Node.js version ${version} is no longer supported.\n\n` +
'expo-cli supports following Node.js versions:\n' +
versionInfo
)
Expand Down