This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] Get xdl-manifests from apiv2 endpoint #1978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How
There are two locations xdl-manifests are fetched. For the first one in
packages/xdl/gulp/build-tasks.js
replaced the url. Confirmed this worked by repopulating the schema cache (git diff is empty):For the second location, Line 69 in
packages/xdl/src/project/ExpSchema.ts
:XdlSchemaClient
.~/.expo/caches/
was repopulated by runningexpo start
in an expo project. (Note: you have to delete~/expo-cli/packages/xdl/caches/*
before running this test to force the repopulation to happen from the endpoint instead of the local backup.)