-
Notifications
You must be signed in to change notification settings - Fork 478
[cli] refactor IQuit, contextual errors #1891
Conversation
@@ -123,6 +124,15 @@ See https://docs.expo.io/versions/latest/distribution/building-standalone-apps/# | |||
} | |||
await this.produceCredentials(context, experienceName, bundleIdentifier); | |||
} catch (e) { | |||
if (e.code === ErrorCodes.NON_INTERACTIVE) { | |||
const here = terminalLink('here', 'https://expo.fyi/credentials-non-interactive'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const here = terminalLink('here', 'https://expo.fyi/credentials-non-interactive'); | |
const here = terminalLink('expo.fyi/credentials-non-interactive', 'https://expo.fyi/credentials-non-interactive'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know i suggested something different but i think this maybe makes it stand out a bit more!
thanks! this is an improvement if it's not too much trouble it would be nice in a followup pr to not show any text after the error msg, so:
this should become
the issue with the first version is that it can be hard for people to pick apart which error actually matters to them. if we know for certain what the error is that is preventing them from continuing and that is all that we know, then we should show that only. |
efe3901
to
ba0b6df
Compare
why
IOSBuilder
related
#1881
TODO
land expo/fyi#4