This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 477
feat(expo-cli): add shortcut to open editor #1879
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
487bd49
feat(expo-cli): add shortcut to open editor
byCedric 4acb8c9
refactor(expo-cli): use spawn async instead of open for editors
byCedric 5ece000
refactor(expo-cli): hide open in editor from initial terminal ui
byCedric 6ed04e6
Update packages/expo-cli/src/commands/utils/EditorUtils.ts
brentvatne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import spawnAsync from '@expo/spawn-async'; | ||
| import editors from 'env-editor'; | ||
| import log from '../../log'; | ||
|
|
||
| export function guessEditor() { | ||
| try { | ||
| return editors.defaultEditor(); | ||
| } catch { | ||
| return editors.getEditor('vscode'); | ||
| } | ||
| } | ||
|
|
||
| export async function startEditorAsync(path: string, options: { editor?: string } = {}) { | ||
| const editor = options.editor ? editors.getEditor(options.editor) : guessEditor(); | ||
|
|
||
| if (editor) { | ||
| try { | ||
| await spawnAsync(editor.binary, [path]); | ||
| return true; | ||
| } catch {} | ||
| } | ||
|
|
||
| log.error( | ||
| 'Could not open editor, you can set it by defining the $EDITOR environment variable with the binary of your editor. (e.g. "code" or "atom")' | ||
| ); | ||
| return false; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what's going on here, looks like the yarn lockfile could be slightly outdated?