This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
refactor: add @expo/dev-server #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fson
force-pushed
the
@fson/metro-dev-server
branch
from
bddf261
to
6b73b35
Compare
EvanBacon
reviewed
Apr 16, 2020
| ); | ||
| } | ||
|
|
||
| type ConsoleLogLevel = 'info' | 'warn' | 'error' | 'debug'; |
EvanBacon
reviewed
Apr 16, 2020
EvanBacon
reviewed
Apr 16, 2020
packages/dev-server/src/middleware/__tests__/clientLogsMiddleware-test.ts
Show resolved
Hide resolved
fson
force-pushed
the
@fson/metro-dev-server
branch
from
5f70eec
to
a6bd7e8
Compare
EvanBacon
reviewed
Apr 19, 2020
EvanBacon
reviewed
Apr 19, 2020
fson
force-pushed
the
@fson/metro-dev-server
branch
from
b6fe237
to
55fbadb
Compare
fson
commented
Apr 22, 2020
fson
force-pushed
the
@fson/metro-dev-server
branch
from
494ec4a
to
d7ea99f
Compare
fson
force-pushed
the
@fson/metro-dev-server
branch
from
9e05f00
to
23f102d
Compare
EvanBacon
reviewed
Apr 28, 2020
EvanBacon
reviewed
Apr 28, 2020
EvanBacon
reviewed
Apr 28, 2020
EvanBacon
reviewed
Apr 28, 2020
| watchFolders: [...metroConfig.watchFolders], | ||
| }); | ||
| middleware.use(bodyParser.json()); | ||
| middleware.use('/logs', clientLogsMiddleware(options.logger)); |
There was a problem hiding this comment.
Maybe add comments here explaining what these middleware features do
EvanBacon
reviewed
Apr 28, 2020
EvanBacon
reviewed
Apr 28, 2020
EvanBacon
reviewed
Apr 28, 2020
| } | ||
|
|
||
| function handleDeviceLogs(logger: Log, deviceId: string, deviceName: string, logs: any) { | ||
| for (let i = 0; i < logs.length; i++) { |
There was a problem hiding this comment.
Suggested change
| for (let i = 0; i < logs.length; i++) { | |
| for (const log of logs) { |
EvanBacon
reviewed
Apr 28, 2020
EvanBacon
reviewed
Apr 28, 2020
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "extends": "@expo/babel-preset-cli/tsconfig.base", | |||
| "include": ["src/**/*.ts"], | |||
There was a problem hiding this comment.
Be sure to exclude tests:
{
"extends": "@expo/babel-preset-cli/tsconfig.base",
"compilerOptions": {
"outDir": "build",
"rootDir": "src"
},
"include": ["src/**/*.ts"],
"exclude": ["**/__mocks__/*", "**/__tests__/*"]
}There was a problem hiding this comment.
I want __tests__ to be type checked however, as far as I know Jest compiles them with Babel which doesn't do type checking? Maybe we can only ignore them in .npmignore or files when publishing to npm?
EvanBacon
reviewed
Apr 28, 2020
packages/xdl/src/Project.ts
Outdated
| options.maxWorkers = startOptions.maxWorkers; | ||
| } | ||
| if (startOptions.target) { | ||
| options.target = startOptions.target; |
There was a problem hiding this comment.
Thoughts on moving EXPO_TARGET here to keep the dev server package more agnostic?
EvanBacon
reviewed
Apr 28, 2020
Comment on lines
+2397
to
+2399
| } else if (getenv.boolish('EXPO_USE_DEV_SERVER', false)) { | ||
| await startDevServerAsync(projectRoot, options); | ||
| DevSession.startSession(projectRoot, exp, 'native'); |
There was a problem hiding this comment.
IIRC we talked about potentially putting this in another file so we could identify and deprecate the legacy code more easily.
There was a problem hiding this comment.
I'd rather do this as a part of splitting up XDL, I'll start working on it soon.
EvanBacon
reviewed
Apr 28, 2020
It had the port number twice
cli-server-api 4.8.0 doesn't include TS declarations
fson
force-pushed
the
@fson/metro-dev-server
branch
from
6303af1
to
5d36147
Compare
Co-Authored-By: Evan Bacon <baconbrix@gmail.com>
Co-Authored-By: Evan Bacon <baconbrix@gmail.com>
Co-Authored-By: Evan Bacon <baconbrix@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1845 +/- ##
=======================================
Coverage 45.09% 45.09%
=======================================
Files 120 120
Lines 4924 4924
Branches 1177 1177
=======================================
Hits 2220 2220
Misses 1898 1898
Partials 806 806 |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@expo/dev-serverwill use the newdev-server-apiand@expo/metro-configpackages to set up a Metro dev server compatible with React Native projects. In addition to the React Native development endpoints, it will include additional endpoints e.g. for serving Expo manifests and receiving logs from Expo client.