Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[cli] fix publish:rollback #1707

Merged
merged 3 commits into from
Apr 13, 2020
Merged

[cli] fix publish:rollback #1707

merged 3 commits into from
Apr 13, 2020

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Mar 20, 2020

why

fixes #596

how

  • change implementation to do a publish:set of the second most recent thing in history for a given sdkVersion, platform and channel instead of actually deleting anything in the history
  • add confirmation with the publication that clients will receive as a result of the rollback
  • move shared methods into PublishUtils

tests

  • repro on a client
  • publish rollback unit tests pass

@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #1707 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1707   +/-   ##
=======================================
  Coverage   60.12%   60.12%           
=======================================
  Files          89       89           
  Lines        2573     2573           
  Branches      667      674    +7     
=======================================
  Hits         1547     1547           
+ Misses       1001      994    -7     
- Partials       25       32    +7     
Impacted Files Coverage Δ
packages/pwa/src/Manifest.ts 37.25% <0.00%> (ø)
packages/config/src/Config.ts 66.66% <0.00%> (ø)
packages/config/src/android/Manifest.ts 69.79% <0.00%> (ø)
...ackages/webpack-config/src/addons/withDevServer.ts 33.33% <0.00%> (ø)
...es/webpack-config/src/loaders/createBabelLoader.ts 46.66% <0.00%> (ø)
...webpack-config/src/plugins/FaviconWebpackPlugin.ts 4.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f8517...d648b56. Read the comment docs.

@brentvatne
Copy link
Member

could you add some unit tests here? ideally all new code being added to expo-cli should improve test coverage

@quinlanj
Copy link
Member Author

@brentvatne here they are! #1724

fix tsc

changes after testing

pr feedback

implementation nits

remove channelId from publish history
@fson
Copy link
Contributor

fson commented Apr 8, 2020

Since --release-channel and --sdk-version are required arguments, if people omit them, we could look up what their most recently published release was and show more contextual instructions how to roll that back:

> expo publish:rollback
--release-channel and --sdk-version arguments are required.
For example, to roll back the release [a1f0c0] on release channel [default] (published 10m ago),
run: expo publish:rollback --release-channel default --sdk-version 37.0.0

packages/expo-cli/src/commands/publish-info.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/publish-info.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/publish-modify.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/publish-modify.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/publish-modify.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/publish-modify.ts Outdated Show resolved Hide resolved
quinlanj and others added 2 commits April 12, 2020 16:43
Co-Authored-By: Brent Vatne <brentvatne@gmail.com>
@brentvatne brentvatne merged commit 133612c into master Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[release-channels] fix publish:rollback
4 participants