This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Improved package name validation #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EvanBacon
commented
Sep 22, 2020
EvanBacon
commented
- fix disallow android reserved words in the package name #2686
|
we should probably explain somewhere what the validation criteria is |
EvanBacon
commented
Sep 23, 2020
| function validatePackage(value: string): boolean { | ||
| return /^[a-zA-Z][a-zA-Z0-9_]*(\.[a-zA-Z][a-zA-Z0-9_]*)+$/.test(value); | ||
| /** | ||
| * Validates an Android package name given the following constraints: https://developer.android.com/studio/build/application-id |
41 tasks
brentvatne
added a commit
that referenced
this pull request
Sep 25, 2020
This reverts commit a1b565e.
brentvatne
added a commit
that referenced
this pull request
Sep 25, 2020
This reverts commit a1b565e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.