Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Separate applicationId from package name #2710

Closed
brentvatne opened this issue Sep 25, 2020 · 2 comments
Closed

Separate applicationId from package name #2710

brentvatne opened this issue Sep 25, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@brentvatne
Copy link
Member

In #2687 we introduced validation on the package name, which is correct and reasonable, however in the managed workflow package name actually more accurately means applicationId - it doesn't actually map to the package name used in the native project, and so different validation rules apply.

We should change this so that developers can specify the applicationId separately. For apps that already are using a package name that is invalid as an actual Java package name but valid as an applicationId, they can change the field name from package to applicationId and continue their development.

applicationId:

  • It must have at least two segments (one or more dots).
  • Each segment must start with a letter.
  • All characters must be alphanumeric or an underscore [a-zA-Z0-9_].
  • Maybe can allow Java reserved words? TBD

packageName:

  • Same as above but...
  • No Java reserved words
  • Should only use lowercase characters
@brentvatne brentvatne added the help wanted Extra attention is needed label Oct 23, 2020
@bbarthec bbarthec self-assigned this Oct 23, 2020
@EvanBacon EvanBacon added the enhancement New feature or request label Jan 19, 2022
@bbarthec bbarthec assigned brentvatne and unassigned bbarthec Jul 14, 2022
@jayshah123
Copy link

Is there a workaround for this? I am using react-native-config which drives applicationId from .env

@byCedric
Copy link
Member

byCedric commented Jan 5, 2024

@brentvatne closing this issue due to inactivity.

@byCedric byCedric closed this as completed Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants