This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 477
Remove external config evaluation script #2625
Merged
EvanBacon
merged 19 commits into
master
from
@evanbacon/config/add-support-for-toggling-config-evaluation-modes
Sep 14, 2020
Merged
Remove external config evaluation script #2625
EvanBacon
merged 19 commits into
master
from
@evanbacon/config/add-support-for-toggling-config-evaluation-modes
Sep 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
added
enhancement
New feature or request
Expo config
Related to the app.json config for Expo projects
labels
Sep 11, 2020
This change might break #2220 by essentially reverting the issue they had initially by default. cc @RedMickey see test failures https://github.com/expo/expo-cli/pull/2625/checks?check_run_id=1101429349 |
brentvatne
reviewed
Sep 12, 2020
EvanBacon
changed the title
Added support for disabling dynamic config evaluation
Remove external config evaluation script
Sep 14, 2020
brentvatne
reviewed
Sep 14, 2020
const config = JsonFile.read(configPath, { json5: true }); | ||
if (config) { | ||
return serializeAndEvaluate(config); | ||
return config as any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmfao ¯_(ツ)_/¯
brentvatne
approved these changes
Sep 14, 2020
EvanBacon
deleted the
@evanbacon/config/add-support-for-toggling-config-evaluation-modes
branch
September 14, 2020 21:24
This was referenced Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
@babel/core
and evaluating it as a string.evalConfig
method.Test Plan
expo start
. Ensured the dynamic behavior was used andConstants.manifest.name
could be updated by reloading the app (⌘+r).