Skip to content
This repository was archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli] base64 decode when saving p8 file #2404

Merged
merged 2 commits into from
Jul 27, 2020
Merged

[expo-cli] base64 decode when saving p8 file #2404

merged 2 commits into from
Jul 27, 2020

Conversation

wkozyra95
Copy link
Contributor

@wkozyra95 wkozyra95 commented Jul 27, 2020 •
edited
Loading

Why

fetch:ios:certs creates push notification key base64 encoded

@wkozyra95 wkozyra95 requested a review from dsokal July 27, 2020 14:09
@wkozyra95 wkozyra95 merged commit 1a6b487 into master Jul 27, 2020
@wkozyra95 wkozyra95 deleted the @wkozyra95/decode-p8-when-saving-to-file branch July 27, 2020 14:31
wkozyra95 added a commit that referenced this pull request Jul 28, 2020
@wkozyra95
[expo-cli] revert PR #2404 and remove encoding from IosPushCredentials
319c9e2
@wkozyra95 wkozyra95 mentioned this pull request Jul 28, 2020
Merged
wkozyra95 added a commit that referenced this pull request Jul 28, 2020
@wkozyra95
[expo-cli] revert PR #2404 and remove encoding from IosPushCredentials (
aa41268 
#2406)

* [expo-cli] revert PR #2404 and remove encoding from IosPushCredentials

* update CHANGELOG
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dsokal dsokal dsokal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkozyra95 @dsokal