[webpack-config] fix: handle empty favicons (#2423)

* fix: handle empty favicons * fix: handle empty string
expo · Aug 26, 2020 · 8eea16a · 8eea16a
1 parent bad2c62
commit 8eea16a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/pwa/src/Manifest.ts b/packages/pwa/src/Manifest.ts
@@ -233,8 +233,12 @@ export function getFaviconIconConfig(config: ExpoConfig): IconOptions | null {
     backgroundColor: 'transparent',
   });
 
-  // Allow empty objects
+  // If the favicon is set but empty, we assume that the user does not want us to generate a favicon
   if (typeof config.web?.favicon === 'string') {
+    if (!config.web?.favicon) {
+      return null;
+    }
+
     return validate(config.web.favicon);
   }
   if (typeof config.icon === 'string') {