feat(expo-cli): add menu for build type

packages/expo-cli/src/commands/build/index.js

@@ -8,6 +8,7 @@ import IOSBuilder from './ios/IOSBuilder';
 import AndroidBuilder from './AndroidBuilder';
 import log from '../../log';
 import CommandError from '../../CommandError';
+import { askBuildType } from './utils';
 
 export default (program: any) => {
   program
@@ -53,7 +54,7 @@ export default (program: any) => {
     .description(
       'Build a standalone IPA for your project, signed and ready for submission to the Apple App Store.'
     )
-    .asyncActionProjectDir((projectDir, options) => {
+    .asyncActionProjectDir(async (projectDir, options) => {
       if (options.publicUrl && !UrlUtils.isHttps(options.publicUrl)) {
         throw new CommandError('INVALID_PUBLIC_URL', '--public-url must be a valid HTTPS URL.');
       }
@@ -64,14 +65,10 @@ export default (program: any) => {
         );
         process.exit(1);
       }
-      if (
-        options.type !== undefined &&
-        options.type !== 'archive' &&
-        options.type !== 'simulator'
-      ) {
-        log.error('Build type must be one of {archive, simulator}');
-        process.exit(1);
-      }
+      options.type = await askBuildType(options.type, {
+        archive: 'Deploy the build to the store',
+        simulator: 'Run the build on a simulator',
+      });
       const iosBuilder = new IOSBuilder(projectDir, options);
       return iosBuilder.command();
     });
@@ -91,7 +88,7 @@ export default (program: any) => {
     .description(
       'Build a standalone APK or App Bundle for your project, signed and ready for submission to the Google Play Store.'
     )
-    .asyncActionProjectDir((projectDir, options) => {
+    .asyncActionProjectDir(async (projectDir, options) => {
       if (options.publicUrl && !UrlUtils.isHttps(options.publicUrl)) {
         throw new CommandError('INVALID_PUBLIC_URL', '--public-url must be a valid HTTPS URL.');
       }
@@ -102,6 +99,10 @@ export default (program: any) => {
         );
         process.exit(1);
       }
+      options.type = await askBuildType(options.type, {
+        apk: 'Build a package to deploy to the store or install directly on Android devices',
+        'app-bundle': 'Build an optimized bundle for the store',
+      });
       const androidBuilder = new AndroidBuilder(projectDir, options);
       return androidBuilder.command();
     });

packages/expo-cli/src/commands/build/utils.js

@@ -1,7 +1,9 @@
 import { Versions } from '@expo/xdl';
 import chalk from 'chalk';
+import program from 'commander';
 
 import log from '../../log';
+import prompt from '../../prompt';
 
 async function checkIfSdkIsSupported(sdkVersion, platform) {
   const isSupported = await Versions.canTurtleBuildSdkVersion(sdkVersion, platform);
@@ -16,4 +18,34 @@ async function checkIfSdkIsSupported(sdkVersion, platform) {
   }
 }
 
-export { checkIfSdkIsSupported };
+async function askBuildType(typeFromFlag, availableTypes) {
+  const allowedTypes = Object.keys(availableTypes);
+  const typeIsInvalid = typeFromFlag !== undefined && !allowedTypes.includes(typeFromFlag);
+
+  if (typeFromFlag && !typeIsInvalid) {
+    return typeFromFlag;
+  }
+
+  if (typeIsInvalid) {
+    log.error(`Build type must be one of (${allowedTypes.join(', ')})`);
+
+    if (program.nonInteractive) {
+      process.exit(1);
+    }
+  }
+
+  const { answer } = await prompt({
+    type: 'list',
+    name: 'answer',
+    message: 'Choose the build type you would like:',
+    choices: allowedTypes.map(type => ({
+      value: type,
+      short: type,
+      name: `${type} ${chalk.gray(`- ${availableTypes[type]}`)}`,
+    })),
+  });
+
+  return answer;
+}
+
+export { checkIfSdkIsSupported, askBuildType };