Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Commit

Permalink
[xdl] Add expo-random to SDK39+ iOS shell apps (#2640)
Browse files Browse the repository at this point in the history
Random screen currently soft crashes the standalone iOS apps on SDK39 and for a good reason — `expo-random` native module is not included.
  • Loading branch information
sjchmiela authored Sep 14, 2020
1 parent 2c51e2f commit 696dfbe
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion packages/xdl/src/detach/IosPodsTools.js
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,11 @@ function _renderUnversionedUniversalModulesDependencies(
excludedUnimodules.push('expo-splash-screen', 'expo-updates');
}

const expoModulesThatAreNotUnimodules = [];
if (sdkMajorVersion >= 39) {
expoModulesThatAreNotUnimodules.push(`pod 'EXRandom', path: '../packages/expo-random/ios'`);
}

return indentString(
`
# Install unimodules
Expand All @@ -431,7 +436,11 @@ use_unimodules!(
exclude: [
${excludedUnimodules.map(module => `'${module}'`).join(',\n ')}
],
)`,
)
# Expo modules that are not unimodules
${expoModulesThatAreNotUnimodules.join('\n')}
`,
2
);
} else {
Expand Down

0 comments on commit 696dfbe

Please sign in to comment.