fix mod serialization (#3008)

expo · Dec 9, 2020 · 54b9d4f · 54b9d4f
1 parent 82e2393
commit 54b9d4f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/config/src/Serialize.ts b/packages/config/src/Serialize.ts
@@ -64,7 +64,10 @@ export function serializeAfterStaticPlugins(val: any): any {
     const output: { [key: string]: any } = {};
     for (const property in val) {
       if (val.hasOwnProperty(property)) {
-        if (property === 'plugins' && Array.isArray(val[property])) {
+        if (property === 'mods') {
+          // Don't serialize mods
+          output[property] = val[property];
+        } else if (property === 'plugins' && Array.isArray(val[property])) {
           // Serialize the mods by removing any config plugins
           output[property] = val[property].map(serializeAndEvaluatePlugin);
         } else {

diff --git a/packages/config/src/__tests__/fixtures/plugins/my-plugin.js b/packages/config/src/__tests__/fixtures/plugins/my-plugin.js
@@ -1,4 +1,7 @@
+const { withAndroidManifest } = require('@expo/config-plugins');
+
 module.exports = config => {
   config.slug = 'from-custom-plugin';
-  return config;
+  // test that the mods don't get serialized
+  return withAndroidManifest(config, config => config);
 };