Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Commit

Permalink
feat(webpack): Bump expo to SDK 49 (#4747)
Browse files Browse the repository at this point in the history
* Bump expo to SDK 49

* bump engines

* drop 18

* 16
  • Loading branch information
EvanBacon authored Aug 17, 2023
1 parent 20d41a7 commit 26142c3
Show file tree
Hide file tree
Showing 22 changed files with 13,845 additions and 5,285 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14', '16']
node: ['16']
name: Build with Node ${{ matrix.node }}
steps:
- uses: actions/checkout@v3
Expand All @@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['14', '16']
node: ['16']
package:
[
dev-tools,
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
node: ['14', '16']
node: ['16']
name: Build with Node ${{ matrix.node }}
steps:
- uses: actions/checkout@v3
Expand All @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['14', '16']
node: ['16']
package:
[
create-expo-app,
Expand Down
2 changes: 1 addition & 1 deletion packages/pwa/src/Manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
getConfig,
getNameFromConfig,
getWebOutputPath,
} from '@expo/config';
} from 'expo/config';

import { IconOptions, Manifest, PWAConfig } from './Manifest.types';

Expand Down
4 changes: 2 additions & 2 deletions packages/pwa/src/Manifest.types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ExpoConfig } from '@expo/config';
import { ImageOptions } from '@expo/image-utils';
import type { ImageOptions } from '@expo/image-utils';
import type { ExpoConfig } from 'expo/config';

type ExpoWebConfig = Required<ExpoConfig>['web'];

Expand Down
2 changes: 1 addition & 1 deletion packages/pwa/src/cli.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env node
import { ResizeMode } from '@expo/image-utils';
import type { ResizeMode } from '@expo/image-utils';
import chalk from 'chalk';
import { Command } from 'commander';
import fs from 'fs';
Expand Down
2 changes: 1 addition & 1 deletion packages/pwa/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ExpoConfig } from '@expo/config';
import * as Image from '@expo/image-utils';
import type { ExpoConfig } from 'expo/config';
import * as path from 'path';
import { URL } from 'url';

Expand Down
2 changes: 1 addition & 1 deletion packages/webpack-config/e2e/basic/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default function App() {
style={{ flex: 1, alignItems: 'center', justifyContent: 'center' }}>
<AspectView style={{ aspectRatio: 1, backgroundColor: 'green', width: 40 }} />
<Text testID="basic-text">Open up App.js to start working on your app!</Text>
<Text testID="expo-constants-manifest">{JSON.stringify(Constants.manifest)}</Text>
<Text testID="expo-constants-manifest">{JSON.stringify(Constants.expoConfig)}</Text>
<Text testID="asset-raw-image">{imageAsset}</Text>
<Text testID="asset-raw-font">{fontAsset}</Text>
<Text testID="asset-raw-wildcard">{typeof randomAsset}</Text>
Expand Down
1 change: 0 additions & 1 deletion packages/webpack-config/e2e/basic/app.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export default {
name: 'basic',
description: 'A Neat Expo App',
sdkVersion: '43.0.0',
icon:
'https://github.com/expo/expo/blob/master/templates/expo-template-blank/assets/icon.png?raw=true',
splash: {
Expand Down
7 changes: 5 additions & 2 deletions packages/webpack-config/e2e/basic/babel.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
module.exports = {
presets: ['babel-preset-expo'],
module.exports = function (api) {
api.cache(true);
return {
presets: ['babel-preset-expo'],
};
};
15 changes: 8 additions & 7 deletions packages/webpack-config/e2e/basic/package.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
{
"main": "./index",
"dependencies": {
"expo": "^43.0.0",
"expo-constants": "~12.1.3",
"react": "17.0.1",
"react-dom": "17.0.1",
"react-native-svg": "~12.1.1",
"react-native-web": "0.17.1",
"expo": "^49.0.7",
"expo-constants": "^14.4.2",
"react": "18.2.0",
"react-native": "0.72.3",
"react-dom": "18.2.0",
"react-native-svg": "13.11.0",
"react-native-web": "0.19.6",
"resize-observer-polyfill": "^1.5.1"
},
"devDependencies": {
"@babel/core": "^7.12.9"
"@babel/core": "^7.20.0"
},
"private": true
}
Loading

0 comments on commit 26142c3

Please sign in to comment.