Add renderBackButtonIcon for backButtonIcon customization #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @ide, @jesseruder and @brentvatne to be potential reviewers |
|
@Kudo thanks for this PR, hope it will be merged soon as we currently have a fork for the same reason 😃 |
|
👍 This is really a need! |
|
This is useful, hope it gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
08dc150 is good if we would like to customise all the logic of backButton.
However, there are some good part of internal logics, e.g. https://github.com/exponentjs/ex-navigator/blob/master/ExRouteRenderer.js#L94-L113.
This change proposes a way to only customise the BackIcon component from ExNavigator.
Please feel free to comment and we should discuss here.
Now I think there are too many options (propTypes) in ExNavigator interface.
While enabling
renderBackButtonIcon,barButtonIconStyleis useless and not sure if that would be implicit or not.