Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Finally fix Windows not-ignoring files #2894

Merged
merged 4 commits into from
Feb 9, 2025

Conversation

sjchmiela
Copy link
Contributor

Why

With toNamespacedPath I was finally able to make ignoring files work properly.

How

Removed if (__NORMALIZE) checks.

Test Plan

Ran eas build:inspect on Windows, confirmed no node_modules was copied. Also ran eas build:inspect on macOS, worked too.

@sjchmiela sjchmiela marked this pull request as ready for review February 9, 2025 12:03
Copy link

github-actions bot commented Feb 9, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

@sjchmiela sjchmiela requested a review from szdziedzic February 9, 2025 12:04
Copy link

github-actions bot commented Feb 9, 2025

✅ Thank you for adding the changelog entry!

Copy link

github-actions bot commented Feb 9, 2025

Size Change: -814 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -814 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.64%. Comparing base (a6fc317) to head (77a2b47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2894      +/-   ##
==========================================
- Coverage   52.64%   52.64%   -0.00%     
==========================================
  Files         588      588              
  Lines       23191    23186       -5     
  Branches     4857     4854       -3     
==========================================
- Hits        12207    12204       -3     
+ Misses      10018    10016       -2     
  Partials      966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela merged commit e8ac97c into main Feb 9, 2025
10 checks passed
@sjchmiela sjchmiela deleted the stanley/fix-windows-final branch February 9, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant