Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Enhance eas env:exec command by enabling shell execution for commands #2811

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Jan 10, 2025

Why

Rebase and update of #2788. (couldn't push to remote to update that PR, would be good to get this in soon).

How

Cherry-pick, rebase, apply requested changes.

Test Plan

Same as #2788.

Manual test:

$ neas env:exec preview "npx expo config --json --type publicd" --non-interactive && echo "hello"

$ neas env:exec preview "npx expo config --json --type public" --non-interactive && echo "hello"
{"name":"pkfsapjfasafj...hello

…for commands

* This change allows for better command handling and execution within the environment context.
* Fix command execution in env:exec to handle various command formats properly.
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman requested a review from szdziedzic January 10, 2025 17:13
@wschurman wschurman marked this pull request as ready for review January 10, 2025 17:13
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Jan 10, 2025

Size Change: -2.99 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -2.99 kB (-0.01%)

compressed-size-action

@wschurman wschurman force-pushed the _wschurman/patch-pr-wat branch from 0c6631b to 15e716a Compare January 10, 2025 17:21
Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 52.46%. Comparing base (37a32c9) to head (15e716a).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/exec.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2811      +/-   ##
==========================================
- Coverage   52.48%   52.46%   -0.01%     
==========================================
  Files         583      583              
  Lines       22603    22608       +5     
  Branches     4461     4464       +3     
==========================================
  Hits        11860    11860              
- Misses      10708    10713       +5     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants