Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Enhance eas env:exec command by enabling shell execution for commands #2788

Closed
wants to merge 1 commit into from
Closed

[eas-cli] Enhance eas env:exec command by enabling shell execution for commands #2788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/eas-cli/src/commands/env/exec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,17 @@ export default class EnvExec extends EasCommand {
throw new Error("Invalid environment. Use one of 'production', 'preview', or 'development'.");
}

const firstChar = bash_command[0];
const lastChar = bash_command[bash_command.length - 1];
const cleanCommand =
(firstChar === '"' && lastChar === '"') || (firstChar === "'" && lastChar === "'")
? bash_command.slice(1, -1)
: bash_command;
wschurman marked this conversation as resolved.
Show resolved Hide resolved

return {
nonInteractive: rawFlags['non-interactive'],
environment,
command: bash_command,
command: cleanCommand,
};
}

Expand Down Expand Up @@ -149,7 +156,8 @@ export default class EnvExec extends EasCommand {
environmentVariables: Record<string, string>;
}): Promise<void> {
Log.log(`Running command: ${chalk.bold(command)}`);
const spawnPromise = spawnAsync('bash', ['-c', command], {
const spawnPromise = spawnAsync(command, [], {
shell: true,
Comment on lines -152 to +160
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I fully understand why bash -c doesn't work on CI but it does on my local machine 🤔 Do you fully get it? Do you use Windows on CI by any chance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you fully get it?

Hey Szymon, unfortunately, no... I am baffled too...

Do you use Windows on CI by any chance?

Nope, I use Github actions with runs-on: ubuntu-latest.

It's totally weird, but even the quote issue seems to be happening only on CI...

stdio: ['inherit', 'pipe', 'pipe'],
env: {
...process.env,
Expand Down
Loading