-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli][eas-json] use node18 as tsconfig base #2739
[eas-cli][eas-json] use node18 as tsconfig base #2739
Conversation
Size Change: -22.7 kB (-0.04%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2739 +/- ##
=======================================
Coverage 52.51% 52.51%
=======================================
Files 583 583
Lines 22582 22582
Branches 4452 4452
=======================================
Hits 11856 11856
Misses 10691 10691
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Subscribed to pull request
Generated by CodeMention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable (after merge conflicts are resolved and tests stop failing)
00e73c5
to
ab48012
Compare
✅ Thank you for adding the changelog entry! |
Why
Followup from #2736 (comment)
Standardize TypeScript configuration across packages by adopting the recommended Node.js 18 TypeScript configuration. This helps ensure consistent TypeScript settings and reduces configuration duplication.
How
@tsconfig/node18
dependency toeas-cli
andeas-json
packagesTest Plan
Current tests pass