Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-12116][eas-cli] improve error message displayed when EAS CLI version doesn't satisfy minimal version required specified in eas.json #2341

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

szdziedzic
Copy link
Member

…t satisfy minimal version required specified in `eas.json`
@szdziedzic szdziedzic requested a review from tchayen April 24, 2024 14:07
Copy link
Member

@tchayen tchayen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

Copy link

github-actions bot commented Apr 24, 2024

Size Change: +1.39 kB (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB +1.39 kB (0%)

compressed-size-action

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.67%. Comparing base (d9092e1) to head (bc8ccb1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2341   +/-   ##
=======================================
  Coverage   53.67%   53.67%           
=======================================
  Files         525      525           
  Lines       19268    19268           
  Branches     4068     4068           
=======================================
  Hits        10340    10340           
  Misses       8203     8203           
  Partials      725      725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic
Copy link
Member Author

/changelog-entry chore Improve error message displayed when EAS CLI version doesn't satisfy minimal version required specified in eas.json

Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 9eeaee5 into main Apr 24, 2024
5 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/improve-error-message branch April 24, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants