Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-11445] Add '--verbose-fastlane' flag for verbose fastlane logs #2276

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Mar 11, 2024

Why

ENG-11445 Investigate whether we can expose the "delivery UUID" for a submission

Having Delivery UUID (or requestUUID) simplifies debugging process and contact with Apple technical support. More verbose fastlane pilot logs are also useful for debugging.

How

Delivery UUID (or RequestUUID) can be exposed by passing --verbose flag to fast lane pilot and changing output format to XML. eas command submit accepts new option --verbose-fastlane that gives more detailed insight into upload process, as well as the content of XML result file.

The new flag is passed to submission-worker which adds necessary flags and env variables to fastlane pilot command.

Later we can extract data from XML and display it in a more organised way.

Without flag
image

With flag

image image

Deploy plan

  1. https://github.com/expo/turtle-v2/pull/1731
  2. https://github.com/expo/universe/pull/14707
  3. [ENG-11445] Add '--verbose-fastlane' flag for verbose fastlane logs #2276

Test plan

  1. Run eas submit command with --verbose --verbose-fastlane flags
  2. Logs should contain detailed fastlane logs

Copy link

linear bot commented Mar 11, 2024

Copy link

github-actions bot commented Mar 11, 2024

Size Change: -2.42 kB (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB -2.42 kB (0%)

compressed-size-action

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.67%. Comparing base (b346f96) to head (fce691a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
+ Coverage   53.67%   53.67%   +0.01%     
==========================================
  Files         525      525              
  Lines       19158    19159       +1     
  Branches     4043     4043              
==========================================
+ Hits        10281    10282       +1     
  Misses       8151     8151              
  Partials      726      726              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz
Copy link
Contributor Author

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch from 99cd704 to 2a46c4a Compare March 18, 2024 12:20
@khamilowicz khamilowicz changed the title [ENG-11445] Add 'verbose-logging' flag for verbose fastlane logs [ENG-11445] Add '--verbose-fastlane' flag for verbose fastlane logs Mar 18, 2024
@khamilowicz
Copy link
Contributor Author

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch from 89bc74b to 2af1457 Compare March 18, 2024 13:37
@khamilowicz
Copy link
Contributor Author

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch from 248f1fe to d72c02a Compare March 18, 2024 14:08
@khamilowicz
Copy link
Contributor Author

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

@khamilowicz khamilowicz marked this pull request as ready for review March 18, 2024 14:16
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch from 185bec1 to 6e940b2 Compare March 19, 2024 16:46
@khamilowicz khamilowicz requested a review from szdziedzic March 19, 2024 16:47
@khamilowicz khamilowicz requested a review from szdziedzic March 20, 2024 10:20
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

Let's merge it after WWW lands so we for sure have GQL schema up to date

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch from f37f049 to 3fa9986 Compare March 20, 2024 10:47
@khamilowicz
Copy link
Contributor Author

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch from bd8af2f to a3f35a3 Compare April 2, 2024 09:39
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch from f40c699 to fce691a Compare April 3, 2024 10:00
Copy link

github-actions bot commented Apr 3, 2024

✅ Thank you for adding the changelog entry!

@khamilowicz khamilowicz merged commit e06fc18 into main Apr 3, 2024
9 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-11445-investigate-whether-we-can-expose-the-delivery-uuid-for-a branch April 3, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants