-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-10799][ci][eas-cli][eas-json] test against node 20 and drop support for node 14 #2175
[ENG-10799][ci][eas-cli][eas-json] test against node 20 and drop support for node 14 #2175
Conversation
Size Change: -2.27 kB (0%) Total Size: 55.5 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
=======================================
Coverage 54.22% 54.22%
=======================================
Files 509 509
Lines 18668 18668
Branches 3740 3740
=======================================
Hits 10121 10121
Misses 8526 8526
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we let users know that there's a newer eas-cli
available if they're running an older version? If so, I think I'm ok with bumping major version, since it's a breaking change, and not doing any more communication. I'm also open to other solutions.
yes |
/changelog-entry breaking-change Drop support for Node 14 |
✅ Thank you for adding the changelog entry! |
Why
Node 14 is no longer maintained, Node 20 is the current active
Similar to #1098
How
Test against Node 20, make it the default Node version used to work with EAS CLI.
Drop support for Node 14, it's not maintained for a longer while (even 16 is not maintained anymore). Changing the
engines
value to14.0.0
will make it fail for the people trying to install EAS CLI when using Node 14.Questions
Do we want to announce this change publicly or there is no need for additional communication (Maybe because of the reasons similar to #1098 (review)?) and we can just release it? It will make people using Node 14 unable to install new EAS versions.
End of life date for Node 14 was April 30, 2023.
Test Plan
Tests, test manually using Node 20