[eas-cli] rework expected bundle format for eas publish #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.92 kB (0%) Total Size: 35.8 MB
|
fson
reviewed
Jan 12, 2021
| launchAsset: { | ||
| type: 'bundle', | ||
| contentType: 'application/javascript', | ||
| path: path.resolve(distRoot, metadata.fileMetadata[platform].bundle), |
There was a problem hiding this comment.
Looks like this might result in Cannot read property 'bundle' of undefined, if the bundle doesn't include all platforms? I wonder if we should check that the key exist?
There was a problem hiding this comment.
good point, added validation with @hapi/joi
Co-authored-by: Ville Immonen <ville.immonen@iki.fi>
jkhales
force-pushed
the
@jkhales/rework-eas-bundles
branch
from
8576383
to
3ab91c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Previously we were relying on
expo exportto build the bundles published byeas publish.expo exportturns out to do a lot of unrelated stuff with the assumption the developer is going to use the output for privately hosted static endpoints. The core elements ofexpo exportwere factored out and put into a new commandexpo bundleexpo/expo-cli#3074.expo bundleoutputs the bundle in a new format. This PR updateseas publishto expect this new format.How
Rewrote
collectAssets.Test Plan
Confirmed the
collectAssetsoutput test still passed after updating it to the new formate.Made a test publish after building the bundle in the new format.