Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4968] better spinner placement for multiple builds #1105

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented May 16, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

https://linear.app/expo/issue/ENG-4968/verify-and-probably-fix-eas-cli-p-all-status-update-behavior

How

In case when running eas build -p all, place the spinner next to "Waiting for builds to complete".

Test Plan

Single build

Screenshot 2022-05-16 at 15 06 39

Multiple builds
Screenshot 2022-05-16 at 15 07 18

@linear
Copy link

linear bot commented May 16, 2022

@github-actions
Copy link

github-actions bot commented May 16, 2022

Size Change: -487 B (0%)

Total Size: 25.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 25.4 MB -487 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1105 (3617504) into main (34ecd38) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 3617504 differs from pull request most recent head dfcfa5d. Consider uploading reports for the commit dfcfa5d to get more accurate results

@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
- Coverage   50.25%   50.24%   -0.01%     
==========================================
  Files         346      346              
  Lines       12715    12718       +3     
  Branches     2593     2589       -4     
==========================================
  Hits         6389     6389              
- Misses       5815     5818       +3     
  Partials      511      511              
Impacted Files Coverage Δ
packages/eas-cli/src/build/build.ts 12.85% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ecd38...dfcfa5d. Read the comment docs.

@dsokal dsokal force-pushed the @dsokal/eng-4968 branch from 3617504 to 9524298 Compare May 16, 2022 13:07
@dsokal dsokal marked this pull request as ready for review May 16, 2022 13:08
@dsokal dsokal requested a review from wkozyra95 as a code owner May 16, 2022 13:08
@dsokal dsokal requested review from brentvatne and kbrandwijk May 16, 2022 13:08
@dsokal
Copy link
Contributor Author

dsokal commented May 16, 2022

/changelog-entry chore Better spinner placement for multiple builds.

@dsokal dsokal merged commit 607838c into main May 17, 2022
@dsokal dsokal deleted the @dsokal/eng-4968 branch May 17, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants