Fix for Issue #840 - URL pattern too broad #879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed _URL_PATTERN in language/tokenizer_exceptions.py, using url regex validation pattern from: https://mathiasbynens.be/demo/url-regex
Description
This change will screen out a number of patterns that are not URLs as well as picking up some patterns that were missed.
Test cases were added to test_urls to expose the issue and validate the fix.
Types of changes
Checklist: