Support doc.spans in Example.from_dict #7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
added
enhancement
|
Ah tupley entity format, we cannot leave you. Looks good though! |
adrianeboyd
pushed a commit
to adrianeboyd/spaCy
that referenced
this pull request
Mar 5, 2021
* add support for spans in Example.from_dict * add unit tests * update error to E879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For quick tests, it's useful to be able to define
doc.spansviaExample.from_dict(e.g. for the upcoming coref work)cf also comment here: #6747 (comment). The workaround provided in that PR wouldn't work if the spans are overlapping. See also new unit tests.
Types of change
enhancement
Checklist