New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Doc.copy bugs #6809

Merged

honnibal merged 3 commits into develop from bugfix/doc-copy-simple

Jan 25, 2021

Member

honnibal commented Jan 25, 2021

Avoid letting the Doc object own LexemeC data. Instead all lexemes should be owned by the Vocab. Also avoids weird heuristics.
Copy doc.spans attribute.

honnibal added 3 commits

January 25, 2021 23:25


          Dont let the Doc own LexemeC, to fix Doc.copy

7cceed1


          Copy doc.spans

30b16a8


          Copy doc.spans

dfadd3d

Contributor

adrianeboyd commented Jan 25, 2021

Definitely a fan of getting rid of the weird heuristics here!

honnibal merged commit 42b117e into develop

svlandeg deleted the bugfix/doc-copy-simple branch

January 25, 2021 14:58

polm mentioned this pull request

Refactor lexeme mem passing #12125

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet