Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor fixes #5664

Merged
merged 9 commits into from
Jun 29, 2020
Merged

refactor fixes #5664

merged 9 commits into from
Jun 29, 2020

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Jun 29, 2020 •
edited
Loading

Various fixes related to the refactor from PR #5555
& clean-up of unused Error messages

Types of change

(bug) fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added bug Bugs and behaviour differing from documentation v3.0 Related to v3.0 labels Jun 29, 2020
@honnibal honnibal merged commit 8d3c030 into explosion:develop Jun 29, 2020
@svlandeg svlandeg deleted the fix/scripts branch June 29, 2020 12:40
@polm polm mentioned this pull request Dec 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation v3.0 Related to v3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svlandeg @honnibal