Support custom token/lexeme attribute for vectors #12625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support custom token/lexeme attribute for vectors.
The main goal is to support
LOWER
orNORM
for vector lookups instead of onlyORTH
. Because this attribute should be determined by the vectors themselves (primarily how the data was normalized for training) rather than the model config, the attribute for model vector lookup is moved fromStaticVectors
to a property of theVectors
.Because a
Token
can have a customNORM
that overrides theLexeme
NORM
,Token.get_struct_attr
is used to retrieve the attr value in contexts where aToken
is available.Types of change
Enhancement.
Checklist