-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpanFinder into spaCy from experimental #12507
Conversation
Not sure why the project clone test fails in the Test Python39Linux? |
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
…cific to span_finder)
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
…into add-span-finder
* Add `allow_overlap=True` to span finder scorer
* Ignore labels in span finder scorer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I only had a few minor comments.
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
I'll go ahead and merge this so we can include it in a dev release. I'll be testing it a lot with several demo projects, so if anything crops up we can fix it before the v3.6.0 release. |
Thanks @kadarakos and @adrianeboyd for pushing this one over the line! 🙏 |
Integrating the
span_finder
fromspacy-experimental
intospaCy
.Description
The
SpanFinder
is a component that suggest spans with a very simple tokenwise classifier: it decides for each token if it could be a start and/or end of a span. The code is largely just copied fromspacy-experimental
with the minimum amount of changes required to run the tests.I added a couple of comments with the
XXX
annotation to ask a couple of initial questions about the parts I would consider changing after reading the code.Types of change
Moving
spacy-experimental
component intospaCy
.Checklist