Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spancat-singlelabel score #12469

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

kadarakos
Copy link
Contributor

Add missing span-scores, fix related bug and add corresponding tests.

Description

The spancat component returns for each Span the score (more like probability) corresponding to the assigned label. The spancat_singlelabel was missing this feature as noted by a Prodigy user. Adding the corresponding tests also surfaced a small bug causing a mismatch between the spans and the scores.

Types of change

Adding missing tests and bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@kadarakos kadarakos added bug Bugs and behaviour differing from documentation tests New, missing or incorrect tests feat / spancat Feature: Span Categorizer labels Mar 27, 2023
@adrianeboyd adrianeboyd merged commit 372a908 into explosion:master Mar 29, 2023
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Apr 3, 2023
* debug argmax sort and add span scores

* add missing tests for spanscores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation feat / spancat Feature: Span Categorizer tests New, missing or incorrect tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants