-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spacy.PlainTextCorpusReader.v1
#12122
Add spacy.PlainTextCorpusReader.v1
#12122
Conversation
Completely forgot to stage the tests that I wrote, added now as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick; LGTM otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies if this is a silly question, but why can't this just go in master
instead of v4
?
That's a good question. I didn't need it there, but I could as well rebase it for |
Then we'd just update the tags to "3.5.1" and merge this after 3.5 is tagged/out |
This is a corpus reader that reads plain text corpora with the following format: - UTF-8 encoding - One line per document. - Blank lines are ignored. It is useful for applications where we deal with very large corpora, such as distillation, and don't want to deal with the space overhead of serialized formats. Additionally, many large corpora already use such a text format, keeping the necessary preprocessing to a minimum.
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
Different OS auto delete/sharing semantics are just wonky.
9fdea9d
to
2f9d8f7
Compare
Rebased onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicky comments on the tests...
Description
This is a corpus reader that reads plain text corpora with the following format:
It is useful for applications where we deal with very large corpora, such as distillation, and don't want to deal with the space overhead of serialized formats. Additionally, many large corpora already use such a text format, keeping the necessary preprocessing to a minimum.
Types of change
New feature
Checklist