Skip to content

Commit

Permalink
Merge branch 'master' of https://github.com/explosion/spaCy
Browse files Browse the repository at this point in the history
  • Loading branch information
honnibal committed Apr 23, 2017
2 parents d0e1926 + 42305bc commit df2ac8b
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 6 deletions.
5 changes: 2 additions & 3 deletions spacy/compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
is_linux = sys.platform.startswith('linux')
is_osx = sys.platform == 'darwin'

fix_text = ftfy.fix_text


if is_python2:
bytes_ = str
Expand All @@ -39,9 +41,6 @@
json_dumps = lambda data: ujson.dumps(data, indent=2)


fix_text = lambda text: ftfy.fix_text(text)


def symlink_to(orig, dest):
if is_python2 and is_windows:
import subprocess
Expand Down
7 changes: 4 additions & 3 deletions spacy/tests/test_download.py → spacy/tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,25 @@
from __future__ import unicode_literals

from ..cli.download import download, get_compatibility, get_version, check_error_depr

import pytest


@pytest.mark.parametrize('model', ['en_core_web_md'])
def test_download_get_matching_version_succeeds(model):
def test_cli_download_get_matching_version_succeeds(model):
comp = { model: ['1.7.0', '0.100.0'] }
assert get_version(model, comp)


@pytest.mark.parametrize('model', ['en_core_web_md'])
def test_download_get_matching_version_fails(model):
def test_cli_download_get_matching_version_fails(model):
diff_model = 'test_' + model
comp = { diff_model: ['1.7.0', '0.100.0'] }
with pytest.raises(SystemExit):
assert get_version(model, comp)


@pytest.mark.parametrize('model', [False, None, '', 'all'])
def test_download_no_model_depr_error(model):
def test_cli_download_no_model_depr_error(model):
with pytest.raises(SystemExit):
check_error_depr(model)
13 changes: 13 additions & 0 deletions spacy/tests/test_misc.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# coding: utf-8
from __future__ import unicode_literals

from ..util import ensure_path

from pathlib import Path
import pytest


@pytest.mark.parametrize('text', ['hello/world', 'hello world'])
def test_util_ensure_path_succeeds(text):
path = ensure_path(text)
assert isinstance(path, Path)

0 comments on commit df2ac8b

Please sign in to comment.