Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitivity tests can sometimes fail #35

Closed
expipiplus1 opened this issue May 9, 2020 · 3 comments
Closed

Transitivity tests can sometimes fail #35

expipiplus1 opened this issue May 9, 2020 · 3 comments

Comments

@expipiplus1
Copy link
Owner

cabal run test -- --quickcheck-replay=538538 -p transitive

@cdepillabout
Copy link

Recently saw this on Hydra on x86_64-darwin: https://hydra.nixos.org/build/144127215/nixlog/1

expipiplus1 added a commit that referenced this issue May 29, 2021
It's a bit of a pain, but basically the arbitrary instance could
generate for precision p:

2, 1, 3. Where 2 <= 1 and 2<=3 (because they compare equal at the low
precision p) and hence 1 <= 3 (which is detected and fails the test).
Making the number of bits from the arbitrary instance match p sorts this
out by disallowing that extra precision.

Fixes #35
expipiplus1 pushed a commit that referenced this issue May 29, 2021
- Tweak test suite to fix #35
@expipiplus1
Copy link
Owner Author

Released as https://hackage.haskell.org/package/exact-real-0.12.5

@expipiplus1
Copy link
Owner Author

@cdepillabout Thanks for the prod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants