new benchmark with sum of mvnorm pdfs #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jduerholt
approved these changes
Aug 27, 2024
bofire/benchmarks/single.py
Outdated
| ), | ||
| "valid_y": np.ones(len(X)), | ||
| }, | ||
| index=range(len(X)), |
There was a problem hiding this comment.
This is not necessary as the index is set to the range by default.
| opt_on_boundary: bool = False, | ||
| N_unimportant_inputs: int = 2, | ||
| means: Optional[list] = None, | ||
| covmats: Optional[np.ndarray] = None, |
There was a problem hiding this comment.
It would be nice to also add a seed argument of type seed: Optional[int] = None, to be able to reproduce randomly generated response surfaces.
There was a problem hiding this comment.
We should then also test in the test that it produces the same numbers when a seed is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had fun experimenting with this trying to make benchmarks that I thought were similar to real problems.
Perhaps it might prove interesting and useful to others too.