Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme example #419

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Readme example #419

merged 2 commits into from
Jul 15, 2024

Conversation

bertiqwerty
Copy link
Contributor

@bertiqwerty bertiqwerty commented Jul 15, 2024 •
edited
Loading

The example in the readme used Inputs.sample which is only ok as long as you don't have constraints. Hence I replaced it with RandomSearch. Further, I added a BO-loop, not just one ask-and-tell call and made the example multi-objective.

@bertiqwerty bertiqwerty changed the title Readne example Readme example Jul 15, 2024
@bertiqwerty bertiqwerty requested a review from TobyBoyne July 15, 2024 08:42
TobyBoyne
TobyBoyne requested changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@TobyBoyne TobyBoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And thanks for noting the change about RandomStrategy. I've left a couple of comments but otherwise this is ready to merge.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@TobyBoyne TobyBoyne merged commit bc75560 into main Jul 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobyBoyne TobyBoyne TobyBoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertiqwerty @TobyBoyne