Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove math.inf from ContinuousInput data model #387

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Remove math.inf from ContinuousInput data model #387

merged 1 commit into from
Mar 27, 2024

Conversation

jduerholt
Copy link
Contributor

This PR removes the default (math.inf, math.inf) from the ContiuousInput, as this creates with FastAPI as @jkeupp find out in his PR on the data models from the hackathon.

@jduerholt jduerholt requested a review from bertiqwerty March 26, 2024 19:20
bertiqwerty
bertiqwerty approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@bertiqwerty bertiqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Johannes.

@jduerholt jduerholt merged commit 8fca164 into main Mar 27, 2024
10 checks passed
@jduerholt jduerholt deleted the hotfix/lsr branch March 27, 2024 09:55
jdridder pushed a commit to jdridder/bofire that referenced this pull request Oct 4, 2024
@jduerholt @jdridder
remove math.inf from data model (experimental-design#387)
7d0c353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertiqwerty bertiqwerty bertiqwerty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jduerholt @bertiqwerty